Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add odoc package as a link deps to the driver #1157

Merged
merged 1 commit into from
Jul 11, 2024
Merged

add odoc package as a link deps to the driver #1157

merged 1 commit into from
Jul 11, 2024

Conversation

EmileTrotignon
Copy link
Collaborator

Add the odoc package as a deps to the driver, because it is one.

Now when you do dune exec odoc_driver -- -p ... before doing dune build, it works anyway !

@EmileTrotignon EmileTrotignon added the no changelog This pull request does not need a changelog entry label Jul 10, 2024
@jonludlam
Copy link
Member

This has caught me out before! link_deps seems a bit wierd though, but I can't immediately spot a better solution.

@EmileTrotignon
Copy link
Collaborator Author

I think thats just how you do this @jonludlam

@jonludlam
Copy link
Member

Perhaps the dune docs need updating then! In any case, this fixes a problem in a quite reasonable way, so let's get it in. Thanks!

@jonludlam jonludlam merged commit 9f3548b into ocaml:master Jul 11, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julow Julow Awaiting requested review from Julow

@panglesd panglesd Awaiting requested review from panglesd

Assignees
No one assigned
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmileTrotignon @jonludlam